Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: test/cctest/test-api-interceptors.cc

Issue 2286323002: [api] Add documentation for PropertyQueryCallback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@DocPropertyAttribute
Patch Set: Improve note about triggering in some cases. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api-interceptors.cc
diff --git a/test/cctest/test-api-interceptors.cc b/test/cctest/test-api-interceptors.cc
index 6e4c6028e90eb78990cdfdd42391b90ccd7346d7..8d42f4dc00e9e6049975648440dce20a7de396f8 100644
--- a/test/cctest/test-api-interceptors.cc
+++ b/test/cctest/test-api-interceptors.cc
@@ -346,6 +346,102 @@ void InterceptorHasOwnPropertyGetterGC(
} // namespace
+int query_counter_int = 0;
+
+namespace {
+void QueryCallback(Local<Name> property,
+ const v8::PropertyCallbackInfo<v8::Integer>& info) {
+ query_counter_int++;
+}
+
+} // namespace
+
+// Examples that show when the query callback is triggered.
+THREADED_TEST(QueryInterceptor) {
+ v8::HandleScope scope(CcTest::isolate());
+ v8::Local<v8::FunctionTemplate> templ =
+ v8::FunctionTemplate::New(CcTest::isolate());
+ templ->InstanceTemplate()->SetHandler(
+ v8::NamedPropertyHandlerConfiguration(0, 0, QueryCallback));
+ LocalContext env;
+ env->Global()
+ ->Set(env.local(), v8_str("obj"), templ->GetFunction(env.local())
+ .ToLocalChecked()
+ ->NewInstance(env.local())
+ .ToLocalChecked())
+ .FromJust();
+ CHECK_EQ(query_counter_int, 0);
+ v8::Local<Value> result =
+ v8_compile("Object.getOwnPropertyDescriptor(obj, 'x');")
+ ->Run(env.local())
+ .ToLocalChecked();
+ CHECK_EQ(query_counter_int, 1);
+ CHECK_EQ(v8::PropertyAttribute::None,
+ static_cast<v8::PropertyAttribute>(
+ result->Int32Value(env.local()).FromJust()));
+
+ v8_compile("Object.defineProperty(obj, 'not_enum', {value: 17});")
+ ->Run(env.local())
+ .ToLocalChecked();
+ CHECK_EQ(query_counter_int, 2);
+
+ v8_compile(
+ "Object.defineProperty(obj, 'enum', {value: 17, enumerable: true, "
+ "writable: true});")
+ ->Run(env.local())
+ .ToLocalChecked();
+ CHECK_EQ(query_counter_int, 3);
+
+ CHECK(v8_compile("obj.propertyIsEnumerable('enum');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 4);
+
+ CHECK(!v8_compile("obj.propertyIsEnumerable('not_enum');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 5);
+
+ CHECK(v8_compile("obj.hasOwnProperty('enum');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 5);
+
+ CHECK(v8_compile("obj.hasOwnProperty('not_enum');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 5);
+
+ CHECK(!v8_compile("obj.hasOwnProperty('x');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 6);
+
+ CHECK(!v8_compile("obj.propertyIsEnumerable('undef');")
+ ->Run(env.local())
+ .ToLocalChecked()
+ ->BooleanValue(env.local())
+ .FromJust());
+ CHECK_EQ(query_counter_int, 7);
+
+ v8_compile("Object.defineProperty(obj, 'enum', {value: 42});")
+ ->Run(env.local())
+ .ToLocalChecked();
+ CHECK_EQ(query_counter_int, 8);
+
+ v8_compile("Object.isFrozen('obj.x');")->Run(env.local()).ToLocalChecked();
+ CHECK_EQ(query_counter_int, 8);
+}
THREADED_TEST(InterceptorHasOwnProperty) {
LocalContext context;
« no previous file with comments | « include/v8.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698