Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: media/capture/video/android/video_capture_device_factory_android.cc

Issue 2286303003: Video capture Android: enable unittests for Camera2 API (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/android/video_capture_device_factory_android.cc
diff --git a/media/capture/video/android/video_capture_device_factory_android.cc b/media/capture/video/android/video_capture_device_factory_android.cc
index 5fb751680683a3c58a1914c72f1a687b13b6a4bd..1928d3b2a5af0a5f4a1c93c9d7914824614e7b63 100644
--- a/media/capture/video/android/video_capture_device_factory_android.cc
+++ b/media/capture/video/android/video_capture_device_factory_android.cc
@@ -43,6 +43,8 @@ VideoCaptureDeviceFactoryAndroid::CreateDevice(
if (video_capture_device->Init())
return std::move(video_capture_device);
+ if (test_mode_)
+ video_capture_device->ConfigureForTesting();
DLOG(ERROR) << "Error creating Video Capture Device.";
return std::unique_ptr<VideoCaptureDevice>();
@@ -105,8 +107,7 @@ void VideoCaptureDeviceFactoryAndroid::GetSupportedFormats(
base::android::ScopedJavaLocalRef<jobject> format(
env, env->GetObjectArrayElement(collected_formats.obj(), i));
- VideoPixelFormat pixel_format =
- media::PIXEL_FORMAT_UNKNOWN;
+ VideoPixelFormat pixel_format = media::PIXEL_FORMAT_UNKNOWN;
switch (media::Java_VideoCaptureFactory_getCaptureFormatPixelFormat(
env, format)) {
case VideoCaptureDeviceAndroid::ANDROID_IMAGE_FORMAT_YV12:
@@ -116,7 +117,8 @@ void VideoCaptureDeviceFactoryAndroid::GetSupportedFormats(
pixel_format = media::PIXEL_FORMAT_NV21;
break;
default:
- continue;
+ // VideoCaptureCamera2 doesn't know the provided format until capture.
+ break;
}
VideoCaptureFormat capture_format(
gfx::Size(
@@ -131,6 +133,15 @@ void VideoCaptureDeviceFactoryAndroid::GetSupportedFormats(
}
}
+bool VideoCaptureDeviceFactoryAndroid::IsLegacyOrDeprecatedDevice(
+ const std::string& device_id) {
+ int id;
+ if (!base::StringToInt(device_id, &id))
+ return true;
+ return (Java_VideoCaptureFactory_isLegacyOrDeprecatedDevice(
+ AttachCurrentThread(), base::android::GetApplicationContext(), id));
+}
+
// static
VideoCaptureDeviceFactory*
VideoCaptureDeviceFactory::CreateVideoCaptureDeviceFactory(

Powered by Google App Engine
This is Rietveld 408576698