Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: cc/surfaces/surface_display_output_surface_unittest.cc

Issue 2286273003: Make cc::Display not own its BeginFrameSource (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_display_output_surface_unittest.cc
diff --git a/cc/surfaces/surface_display_output_surface_unittest.cc b/cc/surfaces/surface_display_output_surface_unittest.cc
index c33557ac0f1224cbc61fec016addf688c292b894..9fed1eda280df05cde84de1608158d139c4249fc 100644
--- a/cc/surfaces/surface_display_output_surface_unittest.cc
+++ b/cc/surfaces/surface_display_output_surface_unittest.cc
@@ -42,17 +42,16 @@ class SurfaceDisplayOutputSurfaceTest : public testing::Test {
FakeOutputSurface::Create3d();
display_output_surface_ = display_output_surface.get();
- std::unique_ptr<BeginFrameSource> begin_frame_source(
- new BackToBackBeginFrameSource(
- base::MakeUnique<DelayBasedTimeSource>(task_runner_.get())));
+ begin_frame_source_.reset(new BackToBackBeginFrameSource(
+ base::MakeUnique<DelayBasedTimeSource>(task_runner_.get())));
int max_frames_pending = 2;
std::unique_ptr<DisplayScheduler> scheduler(new DisplayScheduler(
- begin_frame_source.get(), task_runner_.get(), max_frames_pending));
+ begin_frame_source_.get(), task_runner_.get(), max_frames_pending));
display_.reset(new Display(
&bitmap_manager_, &gpu_memory_buffer_manager_, RendererSettings(),
- std::move(begin_frame_source), std::move(display_output_surface),
+ begin_frame_source_.get(), std::move(display_output_surface),
std::move(scheduler),
base::MakeUnique<TextureMailboxDeleter>(task_runner_.get())));
delegated_output_surface_.reset(new SurfaceDisplayOutputSurface(
@@ -106,6 +105,7 @@ class SurfaceDisplayOutputSurfaceTest : public testing::Test {
scoped_refptr<TestContextProvider> context_provider_;
FakeOutputSurface* display_output_surface_ = nullptr;
std::unique_ptr<Display> display_;
+ std::unique_ptr<BeginFrameSource> begin_frame_source_;
FakeOutputSurfaceClient delegated_output_surface_client_;
std::unique_ptr<SurfaceDisplayOutputSurface> delegated_output_surface_;
};

Powered by Google App Engine
This is Rietveld 408576698