Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2286243002: Remove a commented out DCHECK (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a commented out DCHECK This DCHECK contradicts the DCHECK above it, so it's obsolete. Committed: https://crrev.com/da3d1c42c2d8744fc014626955a26b246369e03c Cr-Commit-Position: refs/heads/master@{#415189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M net/url_request/url_request_job.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
falken
It looks like the request_->NotifyReadCompleted() call at the end will set the status.
4 years, 3 months ago (2016-08-29 05:39:13 UTC) #4
falken
The referenced bug is internal b/1004233 which I'll close if this patch is ok.
4 years, 3 months ago (2016-08-29 05:46:21 UTC) #5
mmenke
On 2016/08/29 05:46:21, falken wrote: > The referenced bug is internal b/1004233 which I'll close ...
4 years, 3 months ago (2016-08-29 14:45:23 UTC) #6
mmenke
On 2016/08/29 14:45:23, mmenke wrote: > On 2016/08/29 05:46:21, falken wrote: > > The referenced ...
4 years, 3 months ago (2016-08-29 14:45:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286243002/1
4 years, 3 months ago (2016-08-29 22:57:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:57:44 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:59:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da3d1c42c2d8744fc014626955a26b246369e03c
Cr-Commit-Position: refs/heads/master@{#415189}

Powered by Google App Engine
This is Rietveld 408576698