Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 22862009: Use CheckUsesForFlag to check flag in uses list (Closed) Base URL: https://github.com/v8/v8.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 right = UseFixed(right_value, rcx); 727 right = UseFixed(right_value, rcx);
728 } 728 }
729 729
730 // Shift operations can only deoptimize if we do a logical shift by 0 and 730 // Shift operations can only deoptimize if we do a logical shift by 0 and
731 // the result cannot be truncated to int32. 731 // the result cannot be truncated to int32.
732 bool does_deopt = false; 732 bool does_deopt = false;
733 if (op == Token::SHR && constant_value == 0) { 733 if (op == Token::SHR && constant_value == 0) {
734 if (FLAG_opt_safe_uint32_operations) { 734 if (FLAG_opt_safe_uint32_operations) {
735 does_deopt = !instr->CheckFlag(HInstruction::kUint32); 735 does_deopt = !instr->CheckFlag(HInstruction::kUint32);
736 } else { 736 } else {
737 for (HUseIterator it(instr->uses()); !it.Done(); it.Advance()) { 737 does_deopt = !instr->CheckUsesForFlag(HValue::kTruncatingToInt32);
738 if (!it.value()->CheckFlag(HValue::kTruncatingToInt32)) {
739 does_deopt = true;
740 break;
741 }
742 }
743 } 738 }
744 } 739 }
745 740
746 LInstruction* result = 741 LInstruction* result =
747 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt)); 742 DefineSameAsFirst(new(zone()) LShiftI(op, left, right, does_deopt));
748 return does_deopt ? AssignEnvironment(result) : result; 743 return does_deopt ? AssignEnvironment(result) : result;
749 } 744 }
750 745
751 746
752 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op, 747 LInstruction* LChunkBuilder::DoArithmeticD(Token::Value op,
(...skipping 1779 matching lines...) Expand 10 before | Expand all | Expand 10 after
2532 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2527 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2533 LOperand* object = UseRegister(instr->object()); 2528 LOperand* object = UseRegister(instr->object());
2534 LOperand* index = UseTempRegister(instr->index()); 2529 LOperand* index = UseTempRegister(instr->index());
2535 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2530 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2536 } 2531 }
2537 2532
2538 2533
2539 } } // namespace v8::internal 2534 } } // namespace v8::internal
2540 2535
2541 #endif // V8_TARGET_ARCH_X64 2536 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698