Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: chrome/browser/ui/webui/history_ui.h

Issue 22862006: "domain" item added to HistoryEntry to allow showing IDN in chrome://history/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/history_ui.h
===================================================================
--- chrome/browser/ui/webui/history_ui.h (revision 216076)
+++ chrome/browser/ui/webui/history_ui.h (working copy)
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_
#define CHROME_BROWSER_UI_WEBUI_HISTORY_UI_H_
+#include <string>
+
#include "base/strings/string16.h"
#include "base/timer/timer.h"
#include "base/values.h"
@@ -40,13 +42,16 @@
HistoryEntry(EntryType type, const GURL& url, const string16& title,
base::Time time, const std::string& client_id,
bool is_search_result, const string16& snippet,
- bool blocked_visit);
+ bool blocked_visit, const std::string& languages);
HistoryEntry();
virtual ~HistoryEntry();
// Formats this entry's URL and title and adds them to |result|.
void SetUrlAndTitle(DictionaryValue* result) const;
+ // Formats this entry's displayable domain and adds it to |result|.
+ void SetDisplayableDomain(DictionaryValue* result) const;
+
// Converts the entry to a DictionaryValue to be owned by the caller.
scoped_ptr<DictionaryValue> ToValue(
BookmarkModel* bookmark_model,
@@ -81,6 +86,9 @@
// Whether this entry was blocked when it was attempted.
bool blocked_visit;
+
+ // kAcceptLanguages pref value.
+ std::string languages;
Patrick Dubroy 2013/08/20 14:26:37 Nit: Might as well call this "accept_languages".
};
BrowsingHistoryHandler();
@@ -163,6 +171,9 @@
// Sets the query options for a monthly query, |offset| months ago.
void SetQueryTimeInMonths(int offset, history::QueryOptions* options);
+ // kAcceptLanguages pref value.
+ std::string GetLanguages() const;
Patrick Dubroy 2013/08/20 14:26:37 ...and this, "GetAcceptLanguages()"
+
content::NotificationRegistrar registrar_;
// Consumer for search requests to the history service.

Powered by Google App Engine
This is Rietveld 408576698