Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6620)

Unified Diff: chrome/browser/resources/history/history.js

Issue 22862006: "domain" item added to HistoryEntry to allow showing IDN in chrome://history/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/history_ui.h » ('j') | chrome/browser/ui/webui/history_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
===================================================================
--- chrome/browser/resources/history/history.js (revision 216076)
+++ chrome/browser/resources/history/history.js (working copy)
@@ -87,6 +87,7 @@
this.model_ = model;
this.title_ = result.title;
this.url_ = result.url;
+ this.displayableDomain_ = result.displayableDomain;
this.starred_ = result.starred;
this.snippet_ = result.snippet || '';
@@ -176,7 +177,7 @@
menu.dataset.devicename = self.deviceName;
menu.dataset.devicetype = self.deviceType;
};
- domain.textContent = this.getDomainFromURL_(this.url_);
brettw 2013/08/21 21:54:48 It seems like we should be updating every place wh
+ domain.textContent = this.displayableDomain_;
entryBox.appendChild(time);
« no previous file with comments | « no previous file | chrome/browser/ui/webui/history_ui.h » ('j') | chrome/browser/ui/webui/history_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698