Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tests/Writer32Test.cpp

Issue 22862002: Write NULL as "" so readString() always returns a non-NULL string. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: len 0 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/Writer32Test.cpp
diff --git a/tests/Writer32Test.cpp b/tests/Writer32Test.cpp
index 6ecfcf3edadd87c32b0edcce0ce128de0c1756e7..194164dd1c37959d81b6ecc91c28b4b9c19c91e3 100644
--- a/tests/Writer32Test.cpp
+++ b/tests/Writer32Test.cpp
@@ -24,29 +24,11 @@ static void check_contents(skiatest::Reporter* reporter, const SkWriter32& write
static void test_string_null(skiatest::Reporter* reporter) {
uint8_t storage[8];
SkWriter32 writer(0, storage, sizeof(storage));
- SkReader32 reader(storage, sizeof(storage));
-
- const char* str;
- size_t len;
// Can we write NULL?
writer.writeString(NULL);
- const int32_t null[] = { 0xFFFF };
- check_contents(reporter, writer, null, sizeof(null));
- str = reader.readString(&len);
- REPORTER_ASSERT(reporter, NULL == str);
- REPORTER_ASSERT(reporter, 0 == len);
-
- writer.reset(storage, sizeof(storage));
- reader.rewind();
-
- // Is NULL distinct from ""?
- writer.writeString("");
- const int32_t empty[] = { 0x0, 0x0 };
- check_contents(reporter, writer, empty, sizeof(empty));
- str = reader.readString(&len);
- REPORTER_ASSERT(reporter, 0 == strcmp("", str));
- REPORTER_ASSERT(reporter, 0 == len);
+ const int32_t expected[] = { 0x0, 0x0 };
+ check_contents(reporter, writer, expected, sizeof(expected));
}
static void test_rewind(skiatest::Reporter* reporter) {
« no previous file with comments | « src/core/SkWriter32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698