Issue 228613005: Introduced Atomic8 and added no-barrier Atomic8 accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228613005: Introduced Atomic8 and added no-barrier Atomic8 accessors. (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)

Modified:
6 years, 8 months ago

Reviewers:
Jarin, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Introduced Atomic8 and added no-barrier Atomic8 accessors. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20598

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -0 lines)			Patch
M	src/atomicops.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_arm64_gcc.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_arm_gcc.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_mac.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_mips_gcc.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_tsan.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_x86_gcc.h	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/atomicops_internals_x86_msvc.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	test/cctest/test-atomicops.cc	View	1 2 3	3 chunks	+32 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jarin

lgtm. You might want to add some sanity tests to test/cctest/test-atomicops.cc.

6 years, 8 months ago (2014-04-08 19:32:40 UTC) #2

Hannes Payer (out of office)

6 years, 8 months ago (2014-04-09 08:20:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r20598 (presubmit successful).