Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 22861037: Remove hacks for GC stress builders from cctests. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Remove hacks for GC stress builders from cctests. R=machenbach@chromium.org BUG=cctest Committed: http://code.google.com/p/v8/source/detail?r=16291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M test/cctest/test-api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
These are obsolete now that cctest no longer runs on the GC stress builders.
7 years, 4 months ago (2013-08-23 10:27:32 UTC) #1
Michael Achenbach
Are the FLAG_stress_compaction queries in cctest/test-heap.cc there for the same reason?
7 years, 4 months ago (2013-08-23 10:47:16 UTC) #2
Michael Starzinger
Yes. We could rip them out as well. Not sure whether we should.
7 years, 4 months ago (2013-08-23 10:58:42 UTC) #3
Michael Achenbach
LGTM then. Maybe lets wait with the others...
7 years, 4 months ago (2013-08-23 10:59:53 UTC) #4
Michael Starzinger
7 years, 4 months ago (2013-08-23 11:10:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r16291.

Powered by Google App Engine
This is Rietveld 408576698