Issue 22861013: Support testing the dart2js compiler on the 64 bit vm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22861013: Support testing the dart2js compiler on the 64 bit vm (Closed)

Created:
7 years, 4 months ago by ricow1

Modified:
7 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support testing the dart2js compiler on the 64 bit vm R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26343

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -17 lines)			Patch
	M	tools/bots/bot.py	View		5 chunks	+12 lines, -4 lines	2 comments	Download
	M	tools/bots/compiler.py	View		13 chunks	+20 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://codereview.chromium.org/22861013/diff/1/tools/bots/bot.py File tools/bots/bot.py (right): https://codereview.chromium.org/22861013/diff/1/tools/bots/bot.py#newcode61 tools/bots/bot.py:61: self.arch=arch space around '='

7 years, 4 months ago (2013-08-19 13:25:32 UTC) #2

ricow1

Committed patchset #1 manually as r26343 (presubmit successful).

7 years, 4 months ago (2013-08-20 10:25:33 UTC) #3

ricow1

7 years, 4 months ago (2013-08-20 10:25:50 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/22861013/diff/1/tools/bots/bot.py
File tools/bots/bot.py (right):

https://codereview.chromium.org/22861013/diff/1/tools/bots/bot.py#newcode61
tools/bots/bot.py:61: self.arch=arch
On 2013/08/19 13:25:32, kustermann wrote:
> space around '='

Done.

Expand Messages | Collapse Messages