Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: ui/compositor/test/test_utils.cc

Issue 22861008: Add support for inverse transform animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add more detailed error messages in matrix comparison. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/test/test_utils.cc
diff --git a/ui/compositor/test/test_utils.cc b/ui/compositor/test/test_utils.cc
index dc70b79159b556c5f341a6f2bfb2d3f192cd2ac8..557f5f6e50386bdb15937d0383de7b2b91697b3d 100644
--- a/ui/compositor/test/test_utils.cc
+++ b/ui/compositor/test/test_utils.cc
@@ -10,13 +10,22 @@
namespace ui {
+//TODO(avallee): Make this into a predicate and add some matrix pretty printing.
void CheckApproximatelyEqual(const gfx::Transform& lhs,
const gfx::Transform& rhs) {
for (int i = 0; i < 4; ++i) {
for (int j = 0; j < 4; ++j) {
- EXPECT_FLOAT_EQ(lhs.matrix().get(i, j), rhs.matrix().get(i, j));
+ EXPECT_FLOAT_EQ(lhs.matrix().get(i, j), rhs.matrix().get(i, j))
+ << "(i, j) = (" << i << ", " << j <<")";
}
}
+
+ if (::testing::Test::HasFailure()) {
danakj 2013/08/29 21:22:34 I'm not sure about this, if another test had a fai
avallee 2013/08/30 00:01:46 Yeah, I'm not sure about this either. What I actua
danakj 2013/08/30 00:04:09 Oh I see. I guess that's why I used side effects i
avallee 2013/09/04 15:04:41 Done.
+ ADD_FAILURE() << "Expected matrix:\n"
+ << lhs.ToString() << "\n"
+ << "Actual matrix:\n"
+ << rhs.ToString();
+ }
}
void CheckApproximatelyEqual(const gfx::Rect& lhs, const gfx::Rect& rhs) {

Powered by Google App Engine
This is Rietveld 408576698