Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 228603004: Move manifest_handler_helpers to //extensions (Closed)

Created:
6 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 8 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move manifest_handler_helpers to //extensions BUG=359836 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -112 lines) Patch
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/manifest_handler_helpers.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/common/extensions/manifest_handler_helpers.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handler_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handler_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
PTAL. It's a mechanical move of manifest_handler_helpers.{cc,h} out of //chrome and into //extensions. Thanks!
6 years, 8 months ago (2014-04-08 15:05:36 UTC) #1
Jeffrey Yasskin
lgtm
6 years, 8 months ago (2014-04-08 16:07:00 UTC) #2
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 8 months ago (2014-04-08 16:29:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/228603004/1
6 years, 8 months ago (2014-04-08 16:30:23 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 18:49:05 UTC) #5
Message was sent while issue was closed.
Change committed as 262464

Powered by Google App Engine
This is Rietveld 408576698