Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2286023002: Fix the test case added in https://codereview.chromium.org/2277063003/ (Closed)

Created:
4 years, 3 months ago by tonikitoo
Modified:
4 years, 3 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix the test case added in https://codereview.chromium.org/2277063003/ In [1], it was made a mistake in the way the test case testing/resources/pixel/bug_492.pdf was generated. This CL aims at fixing this mistake by: 1- keep making use of the new pdfium_test capability introduced by [1], 2- add a proper .in file for the test case to generate its respective .pdf file. [1] https://codereview.chromium.org/2277063003/ BUG=pdfium:492 Committed: https://pdfium.googlesource.com/pdfium/+/5283e674fecf3732d89a8f7f144545af2301ccec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A testing/resources/pixel/bug_492.in View 1 chunk +64 lines, -0 lines 0 comments Download
D testing/resources/pixel/bug_492.pdf View Binary file 0 comments Download
M testing/resources/pixel/bug_492.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 9 (5 generated)
tonikitoo
4 years, 3 months ago (2016-08-27 02:38:10 UTC) #3
dsinclair
lgtm
4 years, 3 months ago (2016-08-29 15:59:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286023002/1
4 years, 3 months ago (2016-08-29 15:59:32 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 16:15:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5283e674fecf3732d89a8f7f144545af2301...

Powered by Google App Engine
This is Rietveld 408576698