Turn off svg for mac valgrind....

Turn off svg for mac valgrind.
Try and buy some time since we're otherwise out of address space.
(See linker error here:
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/5085/steps/compile/logs/stdio
)

Long term solution is to move to 10.6 (64bit linker).
That path has shown to work (resolve linker issues) for the coverage bot so it shows promise.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48426

[John Grabowski, 2010-05-27 19:24:07]

To be clear, I didn't test this properly.  When I 'make start && make log' for
the memory master I get the error (below) which is unrelated to my changes.

my scripts/common/chromium_config.py has a Master class not no
Master.ChromiumMemory class or method.  

Ideas?  



	Traceback (most recent call last):
	  File "/Volumes/work/bb/pylibs/twisted/scripts/_twistd_unix.py", line 310, in
startApplication
	    app.startApplication(application, not self.config['no_save'])
	  File "/Volumes/work/bb/pylibs/twisted/application/app.py", line 635, in
startApplication
	    service.IService(application).startService()
	  File "/Volumes/work/bb/pylibs/twisted/application/service.py", line 260, in
startService
	    service.startService()
	  File "/Volumes/work/bb/pylibs/buildbot/master.py", line 432, in startService
	    self.loadTheConfigFile()
	--- <exception caught here> ---
	  File "/Volumes/work/bb/pylibs/buildbot/master.py", line 488, in
loadTheConfigFile
	    self.loadConfig(f)
	  File "/Volumes/work/bb/pylibs/buildbot/master.py", line 506, in loadConfig
	    exec f in localDict
	  File "/Volumes/work/bb/master.chromium.memory/master.cfg", line 47, in
<module>
	    ActiveMaster = config.Master.ChromiumMemory

[Mark Mentovai - out til August, 2010-05-27 19:28:41]

LGTM

[bradn, 2010-05-27 20:23:13]

LGTM

On Thu, May 27, 2010 at 12:24 PM, <jrg@chromium.org> wrote:

> Reviewers: Mark Mentovai, bradnelson,
>
> Message:
> To be clear, I didn't test this properly.  When I 'make start && make log'
> for
> the memory master I get the error (below) which is unrelated to my changes.
>
> my scripts/common/chromium_config.py has a Master class not no
> Master.ChromiumMemory class or method.
>
> Ideas?
>
>
>
>        Traceback (most recent call last):
>          File "/Volumes/work/bb/pylibs/twisted/scripts/_twistd_unix.py",
> line 310, in
> startApplication
>            app.startApplication(application, not self.config['no_save'])
>          File "/Volumes/work/bb/pylibs/twisted/application/app.py", line
> 635, in
> startApplication
>            service.IService(application).startService()
>          File "/Volumes/work/bb/pylibs/twisted/application/service.py",
> line 260, in
> startService
>            service.startService()
>          File "/Volumes/work/bb/pylibs/buildbot/master.py", line 432, in
> startService
>            self.loadTheConfigFile()
>        --- <exception caught here> ---
>          File "/Volumes/work/bb/pylibs/buildbot/master.py", line 488, in
> loadTheConfigFile
>            self.loadConfig(f)
>          File "/Volumes/work/bb/pylibs/buildbot/master.py", line 506, in
> loadConfig
>            exec f in localDict
>          File "/Volumes/work/bb/master.chromium.memory/master.cfg", line
> 47, in
> <module>
>            ActiveMaster = config.Master.ChromiumMemory
>
>
>
> Description:
> Turn off svg for mac valgrind.
> Try and buy some time since we're otherwise out of address space.
> (See linker error here:
>
>
http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind...
> )
>
> Long term solution is to move to 10.6 (64bit linker).
> That path has shown to work (resolve linker issues) for the coverage bot so
> it
> shows promise.
>
>
> Please review this at http://codereview.chromium.org/2286002/show
>
> SVN Base: svn://
> svn.chromium.org/chrome/trunk/tools/buildbot/master.chromium.memory/
>
> Affected files:
>  M     master.cfg
>
>
> Index: master.cfg
> ===================================================================
> --- master.cfg  (revision 48414)
> +++ master.cfg  (working copy)
> @@ -182,6 +182,9 @@
>
>  valgrind_gyp_defines =
> chromium_factory.ChromiumFactory.MEMORY_TOOLS_GYP_DEFINES
>
> +# Running out of address space on 10.5... try to buy some time.
> +valgrind_mac_gyp_defines = valgrind_gyp_defines + ' enable_svg=0'
> +
>  heapcheck_gyp_defines = (
>   'linux_use_tcmalloc=1 '
>   'linux_use_heapchecker=1 '
> @@ -303,7 +306,7 @@
>     target = 'Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': {'GYP_DEFINES' : valgrind_gyp_defines} },
> +        'gclient_env': {'GYP_DEFINES' : valgrind_mac_gyp_defines} },
>     tests=['valgrind_app',
>            'valgrind_base',
>            'valgrind_googleurl',
> @@ -318,7 +321,7 @@
>     target='Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': {'GYP_DEFINES' : valgrind_gyp_defines} },
> +        'gclient_env': {'GYP_DEFINES' : valgrind_mac_gyp_defines} },
>     tests=['tsan_base',
>            'tsan_googleurl',
>            'tsan_net',
> @@ -336,7 +339,7 @@
>     target='Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': { 'GYP_DEFINES' : valgrind_gyp_defines}},
> +        'gclient_env': { 'GYP_DEFINES' : valgrind_mac_gyp_defines}},
>     options=['--', '-project', '../chrome/chrome.xcodeproj',
>              '-target', 'ui_tests'])
>
> @@ -346,7 +349,7 @@
>     target='Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': { 'GYP_DEFINES' : valgrind_gyp_defines}},
> +        'gclient_env': { 'GYP_DEFINES' : valgrind_mac_gyp_defines}},
>     options=['--', '-project', '../chrome/chrome.xcodeproj',
>              '-target', 'ui_tests'])
>
> @@ -356,7 +359,7 @@
>     target='Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': { 'GYP_DEFINES' : valgrind_gyp_defines}},
> +        'gclient_env': { 'GYP_DEFINES' : valgrind_mac_gyp_defines}},
>     options=['--', '-project', '../chrome/chrome.xcodeproj',
>              '-target', 'ui_tests'])
>
> @@ -366,7 +369,7 @@
>     target='Debug',
>     factory_properties={
>         'needs_valgrind' : True,
> -        'gclient_env': { 'GYP_DEFINES' : valgrind_gyp_defines}},
> +        'gclient_env': { 'GYP_DEFINES' : valgrind_mac_gyp_defines}},
>     options=['--', '-project', '../chrome/chrome.xcodeproj',
>              '-target', 'ui_tests'])
>
> @@ -374,7 +377,7 @@
>     'webkit-rel-mac-valgrind',
>     factory_properties={
>       'needs_valgrind' : True,
> -      'gclient_env': { 'GYP_DEFINES' : valgrind_gyp_defines } },
> +      'gclient_env': { 'GYP_DEFINES' : valgrind_mac_gyp_defines } },
>     tests=['valgrind_test_shell'],
>     options=['--', '-project',
>              '../webkit/webkit.xcodeproj'])
>
>
>