Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2285983002: Task Manager doesn't show the GPU memory of processes on ChromeOS (Closed)

Created:
4 years, 3 months ago by afakhry
Modified:
4 years, 3 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Task Manager doesn't show the GPU memory of processes on ChromeOS On ozone platforms, the message GpuHostMsg_VideoMemoryUsageStats used to be skipped and not handled. Hence the task manager never received those stats. BUG=629873 TEST=manually open the task manager and show the GPU memory column. Data should be there Committed: https://crrev.com/77b0dcbf37f91f60f35689c1004802331f949ee0 Cr-Commit-Position: refs/heads/master@{#415224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
afakhry
Spang, please review. Thank you!
4 years, 3 months ago (2016-08-27 00:31:39 UTC) #2
spang
lgtm
4 years, 3 months ago (2016-08-29 21:48:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285983002/1
4 years, 3 months ago (2016-08-29 23:59:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:29:24 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:31:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77b0dcbf37f91f60f35689c1004802331f949ee0
Cr-Commit-Position: refs/heads/master@{#415224}

Powered by Google App Engine
This is Rietveld 408576698