remoting/client/plugin/chromoting_instance.cc - Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/chromoting_instance.cc

diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc

index db86865408d44bc7e5560fdd4a2f4df8e4f8c544..14d0803bf2ee1b24667e9d446ea4a98dfd09e8df 100644

--- a/remoting/client/plugin/chromoting_instance.cc

+++ b/remoting/client/plugin/chromoting_instance.cc

@@ -356,7 +356,7 @@ void ChromotingInstance::OnVideoFrameDirtyRegion(

rect_value->AppendInteger(rect.top());

rect_value->AppendInteger(rect.width());

rect_value->AppendInteger(rect.height());

- rects_value->Append(rect_value.release());

+ rects_value->Append(std::move(rect_value));

}

std::unique_ptr<base::DictionaryValue> data(new base::DictionaryValue());