Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/element_util.h

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | content/browser/webrtc/webrtc_internals.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_util.h
diff --git a/chrome/test/chromedriver/element_util.h b/chrome/test/chromedriver/element_util.h
index 445ffcdfdf43ae3cf3d439958195eb93c9a4cabe..3131bd13082e475acbb6b05bf3c22db94209b6cc 100644
--- a/chrome/test/chromedriver/element_util.h
+++ b/chrome/test/chromedriver/element_util.h
@@ -20,9 +20,10 @@ struct Session;
class Status;
class WebView;
-base::DictionaryValue* CreateElement(const std::string& element_id);
+std::unique_ptr<base::DictionaryValue> CreateElement(
+ const std::string& element_id);
-base::Value* CreateValueFrom(const WebPoint& point);
+std::unique_ptr<base::DictionaryValue> CreateValueFrom(const WebPoint& point);
// |root_element_id| could be null when no root element is given.
Status FindElement(int interval_ms,
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | content/browser/webrtc/webrtc_internals.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698