Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: device/nfc/nfc_ndef_record_unittest.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Small fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/nfc/nfc_ndef_record_unittest.cc
diff --git a/device/nfc/nfc_ndef_record_unittest.cc b/device/nfc/nfc_ndef_record_unittest.cc
index 2c105d98293f6ecaba0f074e67d51f110295a38d..b5704e590a42359dad4a8ec3f3cdbf69b05278a1 100644
--- a/device/nfc/nfc_ndef_record_unittest.cc
+++ b/device/nfc/nfc_ndef_record_unittest.cc
@@ -9,6 +9,7 @@
#include <memory>
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -198,7 +199,7 @@ TEST(NfcNdefRecordTest, PopulateSmartPoster) {
// Title value with missing required field.
DictionaryValue* title_value = new DictionaryValue();
- list_value->Append(title_value);
+ list_value->Append(base::WrapUnique(title_value));
EXPECT_FALSE(record->Populate(NfcNdefRecord::kTypeSmartPoster, &data));
EXPECT_FALSE(record->IsPopulated());

Powered by Google App Engine
This is Rietveld 408576698