Remove more usage of the base::ListValue::Append(Value*) overload.

content/browser/accessibility/accessibility_tree_formatter.cc

Index: content/browser/accessibility/accessibility_tree_formatter.cc
diff --git a/content/browser/accessibility/accessibility_tree_formatter.cc b/content/browser/accessibility/accessibility_tree_formatter.cc
index 734fe2b98ecb6ebbace31a4e9ee78b652b654dcc..c5c60391bafd4a22743aba59113746b8451e8922 100644
--- a/content/browser/accessibility/accessibility_tree_formatter.cc
+++ b/content/browser/accessibility/accessibility_tree_formatter.cc
@@ -7,8 +7,10 @@
 #include <stddef.h>
 
 #include <memory>
+#include <utility>
 
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/pattern.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ -61,9 +63,10 @@ void AccessibilityTreeFormatter::RecursiveBuildAccessibilityTree(
 
   for (size_t i = 0; i < ChildCount(node); ++i) {
     BrowserAccessibility* child_node = GetChild(node, i);
-    base::DictionaryValue* child_dict = new base::DictionaryValue;
-    children->Append(child_dict);
-    RecursiveBuildAccessibilityTree(*child_node, child_dict);
+    std::unique_ptr<base::DictionaryValue> child_dict(
+        new base::DictionaryValue);
+    RecursiveBuildAccessibilityTree(*child_node, child_dict.get());

[danakj, 2016/08/27 00:07:14]

Wait.. doesn't this change the order. Now we recurse then append. So the first
child will become the last?

[dcheng, 2016/08/30 06:47:48]

No, the recursive call builds the child node, which we then append here.
Everything is still appended in the same order, since the actual child append
takes place in this loop.

[danakj, 2016/09/06 21:55:39]

Oh ya ok, you right. Children will not see themselves in the |children| list
anymore. But that's local so seems okay.

+    children->Append(std::move(child_dict));
   }
 }