Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4655)

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Small fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/element_commands.cc
diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc
index a39b7333517e1704f0739aa7444323f82bd5bedb..124bb4e3c770619ce4e9368e53ffff64c183fc76 100644
--- a/chrome/test/chromedriver/element_commands.cc
+++ b/chrome/test/chromedriver/element_commands.cc
@@ -473,7 +473,7 @@ Status ExecuteGetElementLocationOnceScrolledIntoView(
session, web_view, element_id, &offset, &location);
if (status.IsError())
return status;
- value->reset(CreateValueFrom(location));
+ *value = CreateValueFrom(location);
return Status(kOk);
}

Powered by Google App Engine
This is Rietveld 408576698