Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: printing/print_settings_conversion.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/drive_api_requests.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/print_settings_conversion.cc
diff --git a/printing/print_settings_conversion.cc b/printing/print_settings_conversion.cc
index 7cf5cf1dc2487cdebbfe1f6c2da7bfab470012a2..d8add5a8bcbdff8cb4167d9aa5b8ce852db82d5f 100644
--- a/printing/print_settings_conversion.cc
+++ b/printing/print_settings_conversion.cc
@@ -8,7 +8,9 @@
#include <algorithm>
#include <cmath>
+#include <memory>
#include <string>
+#include <utility>
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -216,10 +218,10 @@ void PrintSettingsToJobSettingsDebug(const PrintSettings& settings,
base::ListValue* page_range_array = new base::ListValue;
job_settings->Set(kSettingPageRange, page_range_array);
for (size_t i = 0; i < settings.ranges().size(); ++i) {
- base::DictionaryValue* dict = new base::DictionaryValue;
- page_range_array->Append(dict);
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
dict->SetInteger(kSettingPageRangeFrom, settings.ranges()[i].from + 1);
dict->SetInteger(kSettingPageRangeTo, settings.ranges()[i].to + 1);
+ page_range_array->Append(std::move(dict));
}
}
« no previous file with comments | « google_apis/drive/drive_api_requests.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698