Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2664)

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_internals_ui.cc ('k') | content/browser/webrtc/webrtc_internals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index 04d52d3f07bfddda0a25b7b23385fa9d9e3421d7..b316624e7284aceed63af419b162c80cf9f2819e 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -166,8 +166,7 @@ ListValue* GetRegistrationListValue(
it != registrations.end();
++it) {
const ServiceWorkerRegistrationInfo& registration = *it;
- std::unique_ptr<class base::DictionaryValue> registration_info(
- new DictionaryValue());
+ std::unique_ptr<DictionaryValue> registration_info(new DictionaryValue());
registration_info->SetString("scope", registration.pattern.spec());
registration_info->SetString(
"registration_id", base::Int64ToString(registration.registration_id));
@@ -198,9 +197,9 @@ ListValue* GetVersionListValue(
versions.begin();
it != versions.end();
++it) {
- DictionaryValue* info = new DictionaryValue();
- UpdateVersionInfo(*it, info);
- result->Append(info);
+ std::unique_ptr<DictionaryValue> info(new DictionaryValue());
+ UpdateVersionInfo(*it, info.get());
+ result->Append(std::move(info));
}
return result;
}
« no previous file with comments | « content/browser/gpu/gpu_internals_ui.cc ('k') | content/browser/webrtc/webrtc_internals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698