Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/browser/accessibility/accessibility_ui.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_ui.cc
diff --git a/content/browser/accessibility/accessibility_ui.cc b/content/browser/accessibility/accessibility_ui.cc
index 53c9863e66be8de99a0910e2c3c734d7f6397a3b..cf0db1142dd83d221b3149888007ff144c90a40f 100644
--- a/content/browser/accessibility/accessibility_ui.cc
+++ b/content/browser/accessibility/accessibility_ui.cc
@@ -4,6 +4,8 @@
#include "content/browser/accessibility/accessibility_ui.h"
+#include <memory>
+
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/json/json_writer.h"
@@ -46,7 +48,7 @@ namespace {
bool g_show_internal_accessibility_tree = false;
-base::DictionaryValue* BuildTargetDescriptor(
+std::unique_ptr<base::DictionaryValue> BuildTargetDescriptor(
const GURL& url,
const std::string& name,
const GURL& favicon_url,
@@ -54,7 +56,8 @@ base::DictionaryValue* BuildTargetDescriptor(
int route_id,
AccessibilityMode accessibility_mode,
base::ProcessHandle handle = base::kNullProcessHandle) {
- base::DictionaryValue* target_data = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> target_data(
+ new base::DictionaryValue());
target_data->SetInteger(kProcessIdField, process_id);
target_data->SetInteger(kRouteIdField, route_id);
target_data->SetString(kUrlField, url.spec());
@@ -66,7 +69,8 @@ base::DictionaryValue* BuildTargetDescriptor(
return target_data;
}
-base::DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh) {
+std::unique_ptr<base::DictionaryValue> BuildTargetDescriptor(
+ RenderViewHost* rvh) {
WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(
WebContents::FromRenderViewHost(rvh));
AccessibilityMode accessibility_mode = AccessibilityModeOff;

Powered by Google App Engine
This is Rietveld 408576698