Remove more usage of the base::ListValue::Append(Value*) overload.

base/json/json_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_JSON_JSON_PARSER_H_
 #define BASE_JSON_JSON_PARSER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 143 matching lines @@
   // This does not advance the parser for non-whitespace or comment chars.
   Token GetNextToken();
 
   // Consumes whitespace characters and comments until the next non-that is
   // encountered.
   void EatWhitespaceAndComments();
   // Helper function that consumes a comment, assuming that the parser is
   // currently wound to a '/'.
   bool EatComment();
 
-  // Calls GetNextToken() and then ParseToken(). Caller owns the result.
-  Value* ParseNextToken();
+  // Calls GetNextToken() and then ParseToken().
+  std::unique_ptr<Value> ParseNextToken();
 
   // Takes a token that represents the start of a Value ("a structural token"
-  // in RFC terms) and consumes it, returning the result as an object the
-  // caller owns.
-  Value* ParseToken(Token token);
+  // in RFC terms) and consumes it, returning the result as a Value.
+  std::unique_ptr<Value> ParseToken(Token token);
 
   // Assuming that the parser is currently wound to '{', this parses a JSON
   // object into a DictionaryValue.
-  Value* ConsumeDictionary();
+  std::unique_ptr<Value> ConsumeDictionary();
 
   // Assuming that the parser is wound to '[', this parses a JSON list into a
-  // ListValue.
-  Value* ConsumeList();
+  // Liststd::unique_ptr<Value>.

[danakj, 2016/08/27 00:07:14]

broken comment

[dcheng, 2016/08/30 06:47:48]

Done.

+  std::unique_ptr<Value> ConsumeList();
 
   // Calls through ConsumeStringRaw and wraps it in a value.
-  Value* ConsumeString();
+  std::unique_ptr<Value> ConsumeString();
 
   // Assuming that the parser is wound to a double quote, this parses a string,
   // decoding any escape sequences and converts UTF-16 to UTF-8. Returns true on
   // success and Swap()s the result into |out|. Returns false on failure with
   // error information set.
   bool ConsumeStringRaw(StringBuilder* out);
   // Helper function for ConsumeStringRaw() that consumes the next four or 10
   // bytes (parser is wound to the first character of a HEX sequence, with the
   // potential for consuming another \uXXXX for a surrogate). Returns true on
   // success and places the UTF8 code units in |dest_string|, and false on
   // failure.
   bool DecodeUTF16(std::string* dest_string);
   // Helper function for ConsumeStringRaw() that takes a single code point,
   // decodes it into UTF-8 units, and appends it to the given builder. The
   // point must be valid.
   void DecodeUTF8(const int32_t& point, StringBuilder* dest);
 
   // Assuming that the parser is wound to the start of a valid JSON number,
   // this parses and converts it to either an int or double value.
-  Value* ConsumeNumber();
+  std::unique_ptr<Value> ConsumeNumber();
   // Helper that reads characters that are ints. Returns true if a number was
   // read and false on error.
   bool ReadInt(bool allow_leading_zeros);
 
   // Consumes the literal values of |true|, |false|, and |null|, assuming the
   // parser is wound to the first character of any of those.
-  Value* ConsumeLiteral();
+  std::unique_ptr<Value> ConsumeLiteral();
 
   // Compares two string buffers of a given length.
   static bool StringsAreEqual(const char* left, const char* right, size_t len);
 
   // Sets the error information to |code| at the current column, based on
   // |index_| and |index_last_line_|, with an optional positive/negative
   // adjustment by |column_adjust|.
   void ReportError(JSONReader::JsonParseError code, int column_adjust);
 
   // Given the line and column number of an error, formats one of the error
@@ skipping 40 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(JSONParserTest, ConsumeNumbers);
   FRIEND_TEST_ALL_PREFIXES(JSONParserTest, ErrorMessages);
 
   DISALLOW_COPY_AND_ASSIGN(JSONParser);
 };
 
 }  // namespace internal
 }  // namespace base
 
 #endif  // BASE_JSON_JSON_PARSER_H_