Remove more usage of the base::ListValue::Append(Value*) overload.

chrome/test/chromedriver/performance_logger_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/performance_logger.h"
 
 #include <stddef.h>
 
+#include <memory>
+#include <utility>
+
 #include "base/compiler_specific.h"
 #include "base/format_macros.h"
 #include "base/json/json_reader.h"
 #include "base/memory/scoped_vector.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/test/chromedriver/chrome/devtools_client_impl.h"
 #include "chrome/test/chromedriver/chrome/log.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 #include "chrome/test/chromedriver/chrome/stub_devtools_client.h"
@@ skipping 289 matching lines @@
   FakeLog log;
   Session session("test");
   PerfLoggingPrefs prefs;
   prefs.trace_categories = "benchmark,blink.console";
   PerformanceLogger logger(&log, &session, prefs);
 
   client.AddListener(&logger);
   logger.OnConnected(&client);
   base::DictionaryValue params;
   base::ListValue* trace_events = new base::ListValue();
-  base::DictionaryValue* event1 = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> event1(new base::DictionaryValue());
   event1->SetString("cat", "foo");
-  trace_events->Append(event1);
-  base::DictionaryValue* event2 = new base::DictionaryValue();
+  trace_events->Append(event1->CreateDeepCopy());
+  std::unique_ptr<base::DictionaryValue> event2(new base::DictionaryValue());
   event2->SetString("cat", "bar");
-  trace_events->Append(event2);
+  trace_events->Append(event2->CreateDeepCopy());
   params.Set("value", trace_events);
   ASSERT_EQ(kOk, client.TriggerEvent("Tracing.dataCollected", params).code());
 
   ASSERT_EQ(2u, log.GetEntries().size());
   ValidateLogEntry(log.GetEntries()[0],
                    DevToolsClientImpl::kBrowserwideDevToolsClientId,
                    "Tracing.dataCollected", *event1);
   ValidateLogEntry(log.GetEntries()[1],
                    DevToolsClientImpl::kBrowserwideDevToolsClientId,
                    "Tracing.dataCollected", *event2);
@@ skipping 43 matching lines @@
   std::string webview;
   EXPECT_TRUE(message->GetString("webview", &webview));
   EXPECT_EQ(DevToolsClientImpl::kBrowserwideDevToolsClientId, webview);
   std::string method;
   EXPECT_TRUE(message->GetString("message.method", &method));
   EXPECT_EQ("Tracing.bufferUsage", method);
   base::DictionaryValue* actual_params;
   EXPECT_TRUE(message->GetDictionary("message.params", &actual_params));
   EXPECT_TRUE(actual_params->HasKey("error"));
 }