Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/test/chromedriver/logging.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/logging.h" 5 #include "chrome/test/chromedriver/logging.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <stdio.h> 9 #include <stdio.h>
10 10
11 #include <memory>
11 #include <utility> 12 #include <utility>
12 13
13 #include "base/command_line.h" 14 #include "base/command_line.h"
14 #include "base/json/json_reader.h" 15 #include "base/json/json_reader.h"
15 #include "base/logging.h" 16 #include "base/logging.h"
16 #include "base/macros.h" 17 #include "base/macros.h"
17 #include "base/strings/stringprintf.h" 18 #include "base/strings/stringprintf.h"
18 #include "base/time/time.h" 19 #include "base/time/time.h"
19 #include "build/build_config.h" 20 #include "build/build_config.h"
20 #include "chrome/test/chromedriver/capabilities.h" 21 #include "chrome/test/chromedriver/capabilities.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 logs.push_back(browser_log); 292 logs.push_back(browser_log);
292 // If the level is OFF, don't even bother listening for DevTools events. 293 // If the level is OFF, don't even bother listening for DevTools events.
293 if (browser_log_level != Log::kOff) 294 if (browser_log_level != Log::kOff)
294 devtools_listeners.push_back(new ConsoleLogger(browser_log)); 295 devtools_listeners.push_back(new ConsoleLogger(browser_log));
295 296
296 out_logs->swap(logs); 297 out_logs->swap(logs);
297 out_devtools_listeners->swap(devtools_listeners); 298 out_devtools_listeners->swap(devtools_listeners);
298 out_command_listeners->swap(command_listeners); 299 out_command_listeners->swap(command_listeners);
299 return Status(kOk); 300 return Status(kOk);
300 } 301 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/element_util.cc ('k') | chrome/test/chromedriver/performance_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698