Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: chrome/test/chromedriver/element_util.h

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_ 5 #ifndef CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_
6 #define CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_ 6 #define CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "chrome/test/chromedriver/basic_types.h" 11 #include "chrome/test/chromedriver/basic_types.h"
12 12
13 namespace base { 13 namespace base {
14 class DictionaryValue; 14 class DictionaryValue;
15 class ListValue; 15 class ListValue;
16 class Value; 16 class Value;
17 } 17 }
18 18
19 struct Session; 19 struct Session;
20 class Status; 20 class Status;
21 class WebView; 21 class WebView;
22 22
23 base::DictionaryValue* CreateElement(const std::string& element_id); 23 std::unique_ptr<base::DictionaryValue> CreateElement(
24 const std::string& element_id);
24 25
25 base::Value* CreateValueFrom(const WebPoint& point); 26 std::unique_ptr<base::DictionaryValue> CreateValueFrom(const WebPoint& point);
26 27
27 // |root_element_id| could be null when no root element is given. 28 // |root_element_id| could be null when no root element is given.
28 Status FindElement(int interval_ms, 29 Status FindElement(int interval_ms,
29 bool only_one, 30 bool only_one,
30 const std::string* root_element_id, 31 const std::string* root_element_id,
31 Session* session, 32 Session* session,
32 WebView* web_view, 33 WebView* web_view,
33 const base::DictionaryValue& params, 34 const base::DictionaryValue& params,
34 std::unique_ptr<base::Value>* value); 35 std::unique_ptr<base::Value>* value);
35 36
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 Status ScrollElementRegionIntoView( 145 Status ScrollElementRegionIntoView(
145 Session* session, 146 Session* session,
146 WebView* web_view, 147 WebView* web_view,
147 const std::string& element_id, 148 const std::string& element_id,
148 const WebRect& region, 149 const WebRect& region,
149 bool center, 150 bool center,
150 const std::string& clickable_element_id, 151 const std::string& clickable_element_id,
151 WebPoint* location); 152 WebPoint* location);
152 153
153 #endif // CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_ 154 #endif // CHROME_TEST_CHROMEDRIVER_ELEMENT_UTIL_H_
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/element_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698