Password bubble: Keep the bubble in sync with the password store.

Password bubble: Keep the bubble in sync with the password store.

When passwords for the current site are added, updated, or removed from
the password store, we should add, update, or remove them from the
bubble in order to keep things up to date.

This patch deals with the common case of removing passwords from the
settings page while the password bubble is instantiated on a separate
tab. A future patch will deal with adding or removing the site from the
blacklist.

BUG=330154
R=vabr@chromium.org,markusheintz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263011

[Mike West, 2014-04-08 12:45:17]

Markus, Vaclav, would you mind taking a look at this patch when you have a few
minutes? I kinda expect it'll need more work, but I think the direction makes
sense. Have I interpreted the password manager innards correctly?

-mike

[vabr (Chromium), 2014-04-08 13:08:34]

Code LGTM, with comments.
I'm not 100% certain I understand why the whole thing still works :), but if it
runs locally and behaves up to Mike's expectations, then that's OK.

Thanks,
Vaclav

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
(right):

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc:25:
origin_(GURL()) {
This initializer is not necessary, origin_ will become an empty GURL
automatically.

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
(right):

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h:105:
PasswordStore* GetPasswordStore(content::WebContents* web_contents);
Could this be (in order of my preference):
1) a helper tucked into the anonymous space,
2) a static method, or
3) a const method?

[Mike West, 2014-04-09 07:06:51]

Thanks!

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
(right):

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc:25:
origin_(GURL()) {
On 2014/04/08 13:08:34, vabr (Chromium) wrote:
> This initializer is not necessary, origin_ will become an empty GURL
> automatically.

Done.

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
File chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
(right):

https://codereview.chromium.org/228593002/diff/1/chrome/browser/ui/passwords/...
chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h:105:
PasswordStore* GetPasswordStore(content::WebContents* web_contents);
On 2014/04/08 13:08:34, vabr (Chromium) wrote:
> Could this be (in order of my preference):
> 1) a helper tucked into the anonymous space,
> 2) a static method, or
> 3) a const method?

A helper method in the anonymous namespace it is!

[vabr (Chromium), 2014-04-09 07:17:31]

Patch set 3 LGTM.
Thanks!

[Mike West, 2014-04-09 18:36:51]

Ping!

[markusheintz_, 2014-04-10 13:22:04]

On 2014/04/09 18:36:51, Mike West wrote:
> Ping!

LGTM

[markusheintz_, 2014-04-10 13:22:12]

https://codereview.chromium.org/228593002/diff/40001/chrome/browser/ui/passwo...
File chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc
(right):

https://codereview.chromium.org/228593002/diff/40001/chrome/browser/ui/passwo...
chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.cc:135: 
nit: remove

[Mike West, 2014-04-10 13:27:48]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-04-10 13:27:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/228593002/50001

[Mike West, 2014-04-10 13:46:55]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-04-10 14:35:20]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[commit-bot: I haz the power, 2014-04-10 14:35:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/228593002/60001

[commit-bot: I haz the power, 2014-04-10 16:42:31]

Change committed as 263011