Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2285923002: Simplify handling of text input types in RenderWidget. (Closed)

Created:
4 years, 3 months ago by dglazkov
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify handling of text input types in RenderWidget. There was some technical debt accrued in UpdateTextInputState, so I cleaned it up a little. R=esprehn BUG= Committed: https://crrev.com/03c1f6703465e6a0289c8799455afb62f87071df Cr-Commit-Position: refs/heads/master@{#415486}

Patch Set 1 #

Patch Set 2 : Fixed the glitch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M content/renderer/render_widget.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 1 6 chunks +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebTextInputType.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dglazkov
Fixed the glitch.
4 years, 3 months ago (2016-08-29 03:05:39 UTC) #5
esprehn
lgtm
4 years, 3 months ago (2016-08-30 21:29:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285923002/20001
4 years, 3 months ago (2016-08-30 21:32:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 23:18:45 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:22:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03c1f6703465e6a0289c8799455afb62f87071df
Cr-Commit-Position: refs/heads/master@{#415486}

Powered by Google App Engine
This is Rietveld 408576698