Implement charToGlyph on remaining ports.

Implement charToGlyph on remaining ports.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11955

[bungeman-skia, 2013-08-26 17:37:23]

In progress implementation of charToGlyph. Works, but is rather slow. In
particular, we should really not be re-creating a SCRIPT_CACHE for each
character in gdi, and DirectWrite will do a run at at time quite nicely.

[reed1, 2013-10-18 13:53:45]

https://codereview.chromium.org/22859070/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.chromium.org/22859070/diff/1/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:121: lf->lfHeight = -12;
Lets add a comment for this (new) magic value -- i.e. want to stay in
bitmap-font range if it was bitmap... don't need giant number to keep metrics
high-precision, etc.

[bungeman-skia, 2013-10-23 22:20:02]

Put a bit of work into this and now have something which is a bit faster and
better tested. Please take a look.

https://codereview.chromium.org/22859070/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.chromium.org/22859070/diff/1/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:121: lf->lfHeight = -12;
On 2013/10/18 13:53:46, reed1 wrote:
> Lets add a comment for this (new) magic value -- i.e. want to stay in
> bitmap-font range if it was bitmap... don't need giant number to keep metrics
> high-precision, etc.

This already got set back to -64 for other reasons a while back. No need to muck
about with it at the moment.

[reed1, 2013-10-24 20:54:20]

lgtm -- why is there an imagedecoder change in this CL?

https://codereview.chromium.org/22859070/diff/78001/tests/ImageDecodingTest.cpp
File tests/ImageDecodingTest.cpp (right):

https://codereview.chromium.org/22859070/diff/78001/tests/ImageDecodingTest.c...
tests/ImageDecodingTest.cpp:180: SkDebugf("Could not run unpremul test because
resourcePath not specified.");
interesting. should this be in this CL?

[bungeman-skia, 2013-10-24 20:58:54]

https://codereview.chromium.org/22859070/diff/78001/tests/ImageDecodingTest.cpp
File tests/ImageDecodingTest.cpp (right):

https://codereview.chromium.org/22859070/diff/78001/tests/ImageDecodingTest.c...
tests/ImageDecodingTest.cpp:180: SkDebugf("Could not run unpremul test because
resourcePath not specified.");
On 2013/10/24 20:54:21, reed1 wrote:
> interesting. should this be in this CL?

Ah, I had it here because I fixed FontHostTest::test_fontstream more or less the
same way and while I was at it noticed this one. I suppose those two changes
could in theory go into another CL.

[bungeman-skia, 2013-10-24 21:39:40]

Committed patchset #3 manually as r11955 (presubmit successful).