Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 22859067: Revert r217952 to make behavior of horizontal scroll bar in page chrome://extensions keep consisten… (Closed)

Created:
7 years, 4 months ago by zhchbin
Modified:
7 years, 3 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert r217952 to make behavior of horizontal scroll bar in page chrome://extensions keep consistence with chrome://settings. This patch also fix issue 269450 using a "no-scroll" css style to remove the scroll bar when showing the overlay in page chrome://extensions. BUG=277974, 269450 TEST=1.Launch chrome & navigate to chrome://extensions/; 2.Zoom the page to 300% or till horizontal scroll bar appears; 3.Try to move the horizontal scroll bar & observe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -68 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 3 chunks +4 lines, -17 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +49 lines, -51 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zhchbin
@miket, Sorry for the trouble I have made. @xiyuan's workaround for fixing http://crbug.com/269450 seems have ...
7 years, 4 months ago (2013-08-24 02:34:15 UTC) #1
zhchbin
@miket, Sorry for the trouble I have made. @xiyuan's workaround for fixing http://crbug.com/269450 seems have ...
7 years, 4 months ago (2013-08-24 02:34:15 UTC) #2
miket_OOO
Revert LGTM
7 years, 3 months ago (2013-08-26 16:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/22859067/1
7 years, 3 months ago (2013-08-26 22:57:03 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-08-27 00:06:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/22859067/1
7 years, 3 months ago (2013-08-27 00:52:51 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-27 03:18:05 UTC) #7
Message was sent while issue was closed.
Change committed as 219671

Powered by Google App Engine
This is Rietveld 408576698