Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 22859063: Converting Skia's SVNCheckout into GitCheckout. (Closed)

Created:
7 years, 4 months ago by rmistry
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, skiabot_google.com, cmp
Base URL:
https://src.chromium.org/chrome/trunk/tools/commit-queue/
Visibility:
Public.

Description

Converting Skia's SVNCheckout into GitCheckout. This CL should not be submitted till: * Skia moves to Git completely. * https://codereview.chromium.org/22794015/ is submitted. CLs I tested this change with are: * https://codereview.chromium.org/22797006/ : Add whitespace in file1 * https://codereview.chromium.org/22815013/ : Remove whitespace from file1 * https://codereview.chromium.org/22867025/ : Add new files in directories * https://codereview.chromium.org/22901018/ : Edit file in directory and delete file in directory * https://codereview.chromium.org/22918014/ : Add, Delete and Modify 3 files * https://codereview.chromium.org/23360004/ : Add new files in new directories

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M pending_manager.py View 1 1 chunk +3 lines, -1 line 0 comments Download
M projects.py View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
https://codereview.chromium.org/22859063/diff/5001/pending_manager.py File pending_manager.py (right): https://codereview.chromium.org/22859063/diff/5001/pending_manager.py#newcode467 pending_manager.py:467: viewvc_url = viewvc_url.rstrip('/') The URL to view a revision ...
7 years, 4 months ago (2013-08-23 16:25:50 UTC) #1
cmp_google
+agable, xusydoc, ilevy, szager
7 years, 3 months ago (2013-08-26 18:24:20 UTC) #2
Mike Stip (use stip instead)
7 years, 3 months ago (2013-08-28 22:58:13 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698