Fix race condition for non-open/create operations happening after a doom.

net/disk_cache/backend_unittest.cc

Index: net/disk_cache/backend_unittest.cc
diff --git a/net/disk_cache/backend_unittest.cc b/net/disk_cache/backend_unittest.cc
index 7eeeee1fd83200c90b0dc1a2775f4654fd903a2f..c9738d007a4748a5595d9adab8cd4a99ebd5fc94 100644
--- a/net/disk_cache/backend_unittest.cc
+++ b/net/disk_cache/backend_unittest.cc
@@ -2682,15 +2682,15 @@ void DiskCacheBackendTest::BackendDoomAll() {
   base::MessageLoop::current()->RunUntilIdle();
 
   disk_cache::Entry *entry3, *entry4;
+  entry1->Close();

[gavinp, 2013/08/26 20:36:50]

Why this?

[Philippe, 2013/08/27 11:33:30]

Good question. I needed this (and the change below) to make the CreateEntry
assertion below (line 2687) pass. Since the entry wasn't closed before the
CreateEntry(), the entry was still active which made CreateEntry() fail. Doom()
is poorly specified in the API but to me it shouldn't (even partly) replace a
Close(). What do you think?

[gavinp, 2013/08/27 15:48:02]

I think this breaks the API; it's legal and should succeed to CreateEntry()
while an entry with the same key is open and doomed.

[Philippe, 2013/08/27 16:11:21]

Ok, thanks I will address that then :)

   EXPECT_NE(net::OK, OpenEntry("third", &entry3));
   ASSERT_EQ(net::OK, CreateEntry("third", &entry3));
+  entry2->Close();
   ASSERT_EQ(net::OK, CreateEntry("fourth", &entry4));
 
   EXPECT_EQ(net::OK, DoomAllEntries());
   ASSERT_EQ(0, cache_->GetEntryCount());
 
-  entry1->Close();
-  entry2->Close();
   entry3->Doom();  // The entry should be already doomed, but this must work.
   entry3->Close();
   entry4->Close();