Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 22859042: Only destroy huffman if build succeeded. (Closed)

Created:
7 years, 4 months ago by scroggo
Modified:
7 years, 3 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Only destroy huffman if build succeeded. The earlier code assumed that if jpeg_create_huffman_index succeeded but jpeg_build_huffman_index failed that the index would still need to be destroyed. This is not the case. Only call jpeg_destroy_huffman_index if both succeeded. BUG=http://b.corp.google.com/issue?id=10263847 Committed: https://code.google.com/p/skia/source/detail?r=10954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scroggo
I've also submitted this CL to android repo for review.
7 years, 4 months ago (2013-08-21 23:50:21 UTC) #1
scroggo
7 years, 3 months ago (2013-08-27 20:42:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r10954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698