tools/dom/scripts/systemnative.py - Issue 22859038: Use new Dart API functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 22859038: Use new Dart API functions (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/systemnative.py

===================================================================

--- tools/dom/scripts/systemnative.py (revision 26407)

+++ tools/dom/scripts/systemnative.py (working copy)

@@ -976,8 +976,13 @@

# Generate to Dart conversion of C++ value.

if return_type_info.dart_type() == 'bool':

set_return_value = 'Dart_SetBooleanReturnValue(args, %s)' % (value_expression)

- elif return_type_info.dart_type() == 'int' and return_type_info.native_type() == 'int':

- set_return_value = 'Dart_SetIntegerReturnValue(args, %s)' % (value_expression)

+ elif return_type_info.dart_type() == 'int':

+ if return_type_info.native_type() == 'unsigned':

+ set_return_value = 'DartUtilities::setDartUnsignedReturnValue(args, %s)' % (value_expression)

+ elif return_type_info.native_type() == 'unsigned long long':

+ set_return_value = 'DartUtilities::setDartUnsignedLongLongReturnValue(args, %s)' % (value_expression)

+ else:

vsm 2013/08/21 22:27:58 Perhaps assert ...native_type() == 'int' here?

siva 2013/08/22 00:46:48 Done.

+ set_return_value = 'DartUtilities::setDartIntegerReturnValue(args, %s)' % (value_expression)

elif return_type_info.dart_type() == 'double':

set_return_value = 'Dart_SetDoubleReturnValue(args, %s)' % (value_expression)

elif return_type_info.dart_type() == 'String':

« no previous file with comments | « no previous file | no next file » | no next file with comments »