Framework to ascribe all network data use to a source.

chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc

Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f2b12b003d27cd94cf270d704317b900849d2dc4
--- /dev/null
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
@@ -0,0 +1,169 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h"
+
+#include "base/bind.h"
+#include "base/memory/ptr_util.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/data_use_measurement/chrome_data_use_ascriber.h"
+#include "chrome/browser/io_thread.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/web_contents.h"
+
+namespace data_use_measurement {
+
+ChromeDataUseAscriberService::ChromeDataUseAscriberService()
+    : ascriber_(nullptr) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  // Skip IO thread initialization if there is no IO thread. This check is
+  // required because unit tests that do no set up an IO thread can cause this
+  // code to execute.
+  if (!g_browser_process->io_thread())
+    return;
+
+  content::BrowserThread::PostTask(

[Lei Zhang, 2016/09/08 22:04:43]

You can also try PostTaskAndReplyWithResult(), then InitOnIOThread() can just be
a function in an anonymous namespace that simply returns
io_thread->globals()->data_use_ascriber.get();

[Not at Google. Contact bengr, 2016/09/09 18:37:16]

Good idea. Done.

+      content::BrowserThread::IO, FROM_HERE,
+      base::Bind(&ChromeDataUseAscriberService::InitOnIOThread,
+                 base::Unretained(this), g_browser_process->io_thread()));
+}
+
+ChromeDataUseAscriberService::~ChromeDataUseAscriberService() {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+}
+
+void ChromeDataUseAscriberService::RenderFrameCreated(
+    content::RenderFrameHost* render_frame_host) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (!ascriber_)
+    return;
+
+  int parent_render_process_id = -1;
+  int parent_render_frame_id = -1;
+  if (render_frame_host->GetParent()) {
+    parent_render_process_id =
+        render_frame_host->GetParent()->GetProcess()->GetID();
+    parent_render_frame_id = render_frame_host->GetParent()->GetRoutingID();
+  }
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO, FROM_HERE,
+      base::Bind(&ChromeDataUseAscriber::RenderFrameCreated,
+                 base::Unretained(ascriber_),
+                 render_frame_host->GetProcess()->GetID(),
+                 render_frame_host->GetRoutingID(), parent_render_process_id,
+                 parent_render_frame_id));
+}
+
+void ChromeDataUseAscriberService::RenderFrameDeleted(
+    content::RenderFrameHost* render_frame_host) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (!ascriber_)
+    return;
+
+  int parent_render_process_id, parent_render_frame_id = -1;

[Lei Zhang, 2016/09/08 22:04:43]

- One decl per line.
- Did |parent_render_process_id| get initialized?

[Not at Google. Contact bengr, 2016/09/09 18:37:16]

Done. Nope, |parent_render_process_id| will not be initialized as written
earlier.

+
+  if (render_frame_host->GetParent()) {
+    parent_render_process_id =
+        render_frame_host->GetParent()->GetProcess()->GetID();
+    parent_render_frame_id = render_frame_host->GetParent()->GetRoutingID();
+  }
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO, FROM_HERE,
+      base::Bind(&ChromeDataUseAscriber::RenderFrameDeleted,
+                 base::Unretained(ascriber_),
+                 render_frame_host->GetProcess()->GetID(),
+                 render_frame_host->GetRoutingID(), parent_render_process_id,
+                 parent_render_frame_id));
+}
+
+void ChromeDataUseAscriberService::DidStartNavigation(
+    content::NavigationHandle* navigation_handle) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (!ascriber_)
+    return;
+
+  if (navigation_handle->IsInMainFrame()) {

[Lei Zhang, 2016/09/08 22:04:43]

I'd just do:

if (!navigation_handle->IsInMainFrame())
  return;

and the PostTask gets 2 more columns to work with.

[Not at Google. Contact bengr, 2016/09/09 18:37:16]

Done.

+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(
+            &ChromeDataUseAscriber::DidStartMainFrameNavigation,
+            base::Unretained(ascriber_), navigation_handle->GetURL(),
+            navigation_handle->GetWebContents()

[Lei Zhang, 2016/09/08 22:04:43]

Create a local variable for navigation_handle->GetWebContents().

[Not at Google. Contact bengr, 2016/09/09 18:37:16]

Done.

+                ->GetRenderProcessHost()
+                ->GetID(),
+            navigation_handle->GetWebContents()->GetMainFrame()->GetRoutingID(),
+            navigation_handle));
+  }
+}
+
+void ChromeDataUseAscriberService::DidFinishNavigation(
+    content::NavigationHandle* navigation_handle) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (!ascriber_)
+    return;
+
+  if (navigation_handle->IsInMainFrame()) {
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(
+            &ChromeDataUseAscriber::DidFinishMainFrameNavigation,
+            base::Unretained(ascriber_), navigation_handle->GetURL(),
+            navigation_handle->GetWebContents()
+                ->GetRenderProcessHost()
+                ->GetID(),
+            navigation_handle->GetWebContents()->GetMainFrame()->GetRoutingID(),
+            !navigation_handle->HasCommitted() ||
+                navigation_handle->IsSamePage(),
+            navigation_handle));
+  }
+}
+
+void ChromeDataUseAscriberService::DidRedirectNavigation(
+    content::NavigationHandle* navigation_handle) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  if (!ascriber_)
+    return;
+
+  if (navigation_handle->IsInMainFrame()) {
+    content::BrowserThread::PostTask(
+        content::BrowserThread::IO, FROM_HERE,
+        base::Bind(
+            &ChromeDataUseAscriber::DidRedirectMainFrameNavigation,
+            base::Unretained(ascriber_), navigation_handle->GetURL(),
+            navigation_handle->GetWebContents()
+                ->GetRenderProcessHost()
+                ->GetID(),
+            navigation_handle->GetWebContents()->GetMainFrame()->GetRoutingID(),
+            navigation_handle));
+  }
+}
+
+void ChromeDataUseAscriberService::InitOnIOThread(IOThread* io_thread) {
+  DCHECK(io_thread);
+  DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
+
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&ChromeDataUseAscriberService::SetDataUseAscriber,
+                 base::Unretained(this),
+                 io_thread->globals()->data_use_ascriber.get()));
+}
+
+void ChromeDataUseAscriberService::SetDataUseAscriber(
+    ChromeDataUseAscriber* ascriber) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+  ascriber_ = ascriber;
+}
+
+}  // namespace data_use_measurement