Issue 22859030: Remove wrapper-link-and-translate from PNaCl and pnacl_shared_newlib from SCons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22859030: Remove wrapper-link-and-translate from PNaCl and pnacl_shared_newlib from SCons. (Closed)

Created:
7 years, 4 months ago by jvoung (off chromium)

Modified:
7 years, 4 months ago

Reviewers:
Derek Schuff, Roland McGrath

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Remove wrapper-link-and-translate from PNaCl and pnacl_shared_newlib from SCons. Most of it was for setting up libraries for tests/pnacl_ld_experiments, but that has been removed. This also removes a driver file "wrapper-link-and-translate" that shouldn't be used by real users. BUG=none (reverts most of commits for issues 2745 and 2765) Also reverts https://chromiumcodereview.appspot.com/10416014, which was not linked to the above issue numbers. R=mcgrathr@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12035

Patch Set 1 #

Patch Set 2 : more references #

Patch Set 3 : simplify #

Patch Set 4 : whitespace #

Patch Set 5 : one more reference #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -506 lines)			Patch
M	SConstruct	View	1 2 3 4	5 chunks	+2 lines, -17 lines	0 comments	Download
M	pnacl/build.sh	View		2 chunks	+1 line, -71 lines	0 comments	Download
M	pnacl/driver/pnacl-translate.py	View	1 2 3 4	3 chunks	+1 line, -9 lines	0 comments	Download
D	pnacl/driver/wrapper-link-and-translate.py	View		1 chunk	+0 lines, -233 lines	0 comments	Download
M	site_scons/site_tools/naclsdk.py	View		2 chunks	+0 lines, -22 lines	0 comments	Download
M	src/untrusted/nacl/nacl.scons	View	1 2 3	2 chunks	+3 lines, -14 lines	0 comments	Download
D	src/untrusted/nacl/pthread_initialize_minimal_using_ldso.c	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	src/untrusted/nacl/tls_using_ldso.c	View		1 chunk	+0 lines, -88 lines	0 comments	Download
M	src/untrusted/nosys/nacl.scons	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/untrusted/pthread/nacl.scons	View	1	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

7 years, 4 months ago (2013-08-20 20:29:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r12035 (presubmit successful).

Expand Messages | Collapse Messages