Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: Source/core/dom/WheelEvent.idl

Issue 22859012: Add support for DOM Level 3 WheelEvent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Simplify test case Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/WheelEvent.idl
diff --git a/Source/core/dom/WheelEvent.idl b/Source/core/dom/WheelEvent.idl
index 9dc0e4a49a26f17bb8196cd986c8b42a5016c544..4cd35d7168b9ded8f8933c9a69f4af1a40c29c49 100644
--- a/Source/core/dom/WheelEvent.idl
+++ b/Source/core/dom/WheelEvent.idl
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2006, 2007, 2010 Apple Inc. All rights reserved.
* Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
@@ -18,17 +19,23 @@
* Boston, MA 02110-1301, USA.
*/
+// Introduced in DOM Level 3:
[
ConstructorTemplate=Event
] interface WheelEvent : MouseEvent {
+ // DeltaModeCode
const unsigned long DOM_DELTA_PIXEL = 0x00;
const unsigned long DOM_DELTA_LINE = 0x01;
const unsigned long DOM_DELTA_PAGE = 0x02;
- [InitializedByEventConstructor] readonly attribute long wheelDeltaX;
- [InitializedByEventConstructor] readonly attribute long wheelDeltaY;
+ [InitializedByEventConstructor] readonly attribute long deltaX;
do-not-use 2013/08/16 09:57:16 These should be "double", not "long". I'll fix thi
do-not-use 2013/08/16 12:02:50 Done.
+ [InitializedByEventConstructor] readonly attribute long deltaY;
+ // [InitializedByEventConstructor] readonly attribute long deltaZ;
[InitializedByEventConstructor] readonly attribute unsigned long deltaMode;
+ // Non standard API.
+ [InitializedByEventConstructor, ImplementedAs=deltaX] readonly attribute long wheelDeltaX;
arv (Not doing code reviews) 2013/08/15 14:05:44 OK. I see, we use the same interface... this shoul
do-not-use 2013/08/16 12:02:50 Right, I use the same interface because the interf
+ [InitializedByEventConstructor, ImplementedAs=deltaY] readonly attribute long wheelDeltaY;
readonly attribute long wheelDelta;
// WebKit Extension

Powered by Google App Engine
This is Rietveld 408576698