Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 22859009: Changes to how we handle fancy stacks: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 26205)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -794,6 +794,10 @@
var vmArguments = new List.from(vmOptions);
vmArguments.addAll([
'--ignore-unrecognized-flags', '$tempDir/out.dart']);
+ // Turn off fancy stacks.
+ if (!configuration['fancy-stacks']) {
+ vmArguments.add('--no-fancy-stacks');
+ }
commands.add(CommandBuilder.instance.getCommand(
"vm", vmFileName, vmArguments, configurationDir));
} else {
@@ -804,6 +808,10 @@
case 'none':
var arguments = new List.from(vmOptions);
arguments.addAll(args);
+ // Turn off fancy stacks.
+ if (!configuration['fancy-stacks']) {
+ arguments.add('--no-fancy-stacks');
+ }
return <Command>[CommandBuilder.instance.getCommand(
'vm', dartShellFileName, arguments, configurationDir)];
@@ -966,13 +974,15 @@
Path expectedOutput = null;
if (new File.fromPath(pngPath).existsSync()) {
expectedOutput = pngPath;
- content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
+ content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"),
+ configuration['fancy-stacks']);
} else if (new File.fromPath(txtPath).existsSync()) {
expectedOutput = txtPath;
- content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
+ content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"),
+ configuration['fancy-stacks']);
} else {
content = getHtmlContents(filename, scriptType,
- new Path("$scriptPath"));
+ new Path("$scriptPath"), configuration['fancy-stacks']);
}
htmlTest.writeStringSync(content);
htmlTest.closeSync();
« pkg/unittest/lib/src/test_case.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698