Changes to how we handle fancy stacks:

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart	(revision 26407)
+++ tools/testing/dart/test_suite.dart	(working copy)
@@ -794,6 +794,12 @@
         var vmArguments = new List.from(vmOptions);
         vmArguments.addAll([
             '--ignore-unrecognized-flags', '$tempDir/out.dart']);
+        // Turn off fancy stacks or stack filtering.
+        if (configuration['raw-stacks']) {

[ricow1, 2013/08/21 12:44:10]

does this work, adding flags _after_ the dart file? (the dart file is above).
Normally these flags are actually given to the executing dart program

[ahe, 2013/08/21 12:48:21]

This is a flag to the Dart program, not the Dart VM.

I'd be concerned about passing command line arguments to Dart programs. It makes
it impossible to test new Options().arguments.

My understanding was that we agreed that the default in non-html configs would
be to not parse stack traces.

[gram, 2013/08/21 17:12:38]

Yes, these are passed to the Dart test. As it provides flexibility in handling
stack traces, it seemed worth doing. It doesn't make it impossible to test
Options (the options test was modified to deal with this); it just makes the
Options tests a bit more tricky to diagnose if they fail, but in that case it is
easy to get these arguments to be excluded by passing the --filter-stacks option
to test.dart. If you look at the Options tests I think you will agree that this
change is incredibly unlikely to introduce a false positive or negative, and the
test should still catch failures if Options actually breaks.

+          vmArguments.add('--no-fancy-stacks');
+        } else if (!configuration['filter-stacks']) {
+          vmArguments.add('--no-filtered-stacks');
+        }
         commands.add(CommandBuilder.instance.getCommand(
             "vm", vmFileName, vmArguments, configurationDir));
       } else {
@@ -804,6 +810,12 @@
     case 'none':
       var arguments = new List.from(vmOptions);
       arguments.addAll(args);
+      // Turn off fancy stacks.
+      if (configuration['raw-stacks']) {
+        arguments.add('--no-fancy-stacks');
+      } else if (!configuration['filter-stacks']) {
+        arguments.add('--no-filtered-stacks');
+      }
       return <Command>[CommandBuilder.instance.getCommand(
           'vm', dartShellFileName, arguments, configurationDir)];
 
@@ -966,13 +978,16 @@
       Path expectedOutput = null;
       if (new File.fromPath(pngPath).existsSync()) {
         expectedOutput = pngPath;
-        content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
+        content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"),
+            !configuration['raw-stacks'], configuration['filter-stacks']);
       } else if (new File.fromPath(txtPath).existsSync()) {
         expectedOutput = txtPath;
-        content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"));
+        content = getHtmlLayoutContents(scriptType, new Path("$scriptPath"),
+          !configuration['raw-stacks'], configuration['filter-stacks']);
       } else {
         content = getHtmlContents(filename, scriptType,
-            new Path("$scriptPath"));
+            new Path("$scriptPath"), !configuration['raw-stacks'],
+            configuration['filter-stacks']);
       }
       htmlTest.writeStringSync(content);
       htmlTest.closeSync();