Enable Site Isolation for Extensions.

Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
Committed: https://crrev.com/d8f0aefde00132b06bd97cb17555f2ec89a0c203
Cr-Commit-Position: refs/heads/master@{#414879}

[nasko, 2016-08-26 21:33:55]

Description was changed from

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
==========

to

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
==========

[alexmos, 2016-08-26 21:34:10]

alexmos@chromium.org changed reviewers:
+ alexmos@chromium.org

[alexmos, 2016-08-26 21:34:10]

LGTM!

[nasko, 2016-08-26 21:34:28]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:35:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:45:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nasko, 2016-08-26 21:53:35]

nasko@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[nasko, 2016-08-26 21:53:36]

Hey Devlin,
Can you review this CL for me? It enables by default Isolated Extensions :).
Thanks in advance!
Nasko

[Devlin, 2016-08-26 22:09:25]

On 2016/08/26 21:53:36, nasko (out until 08-30) wrote:
> Hey Devlin,
> Can you review this CL for me? It enables by default Isolated Extensions :).
> Thanks in advance!
> Nasko

Woohoo!  LGTM!

[nasko, 2016-08-26 22:12:17]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:13:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-08-26 22:16:04]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-26 22:34:36]

Hey Devlin,
Can you check the new PS? I missed the bit exposed to JS for extensions test
initially.
Thanks!
Nasko

[nasko, 2016-08-26 22:35:48]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:36:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-26 22:37:12]

I think you'll also need:
extensions/browser/guest_view/web_view/web_view_apitest.cc

Maybe chrome/browser/extensions/chrome_extension_web_contents_observer.cc too? 
Not sure exactly what that one's doing.

[nasko, 2016-08-26 22:37:26]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-26 22:40:22]

On 2016/08/26 22:37:12, Devlin wrote:
> I think you'll also need:
> extensions/browser/guest_view/web_view/web_view_apitest.cc

Thanks! Fixed.

> Maybe chrome/browser/extensions/chrome_extension_web_contents_observer.cc too?

> Not sure exactly what that one's doing.

That one is responsible for field trial bucketing. This will be cleaned up in a
separate CL and has no impact on whether the feature is on or off by default. It
uses extensions::IsIsolateExtensionsEnabled, which I've fixed to always return
true.

[nasko, 2016-08-26 22:47:49]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-26 22:56:58]

If the bots are happy, re-lgtm. :)

[nasko, 2016-08-26 23:13:17]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2016-08-26 23:13:30]

The CQ bit was checked by nasko@chromium.org

[nasko, 2016-08-26 23:13:30]

The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2285883002/#ps40001
(title: "Fix web_view_apitest.cc too.")

[commit-bot: I haz the power, 2016-08-26 23:14:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 00:28:38]

Description was changed from

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
==========

to

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
==========

[commit-bot: I haz the power, 2016-08-27 00:28:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-27 00:31:38]

Description was changed from

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200
==========

to

==========
Enable Site Isolation for Extensions.

This CL enables isolated extensions. Removal of the command line flag and
the field trial will be done in a separate CL.

BUG=545200

Committed: https://crrev.com/d8f0aefde00132b06bd97cb17555f2ec89a0c203
Cr-Commit-Position: refs/heads/master@{#414879}
==========

[commit-bot: I haz the power, 2016-08-27 00:31:39]

Patchset 3 (id:??) landed as
https://crrev.com/d8f0aefde00132b06bd97cb17555f2ec89a0c203
Cr-Commit-Position: refs/heads/master@{#414879}

[nasko, 2016-10-28 18:05:38]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2456413002/ by nasko@chromium.org.

The reason for reverting is: Moving back to Site Isolation for Extensions being
off by default, until we fix the remaining functional issues..