content/browser/tracing/background_tracing_manager_impl.cc - Issue 2285853002: Reland of Background tracing: Added config option for repeated trigger behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/background_tracing_manager_impl.cc

Issue 2285853002: Reland of Background tracing: Added config option for repeated trigger behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorrect removal Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/tracing/background_tracing_manager_browsertest.cc ('k') | content/browser/tracing/background_tracing_rule.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tracing/background_tracing_manager_impl.cc

diff --git a/content/browser/tracing/background_tracing_manager_impl.cc b/content/browser/tracing/background_tracing_manager_impl.cc

index a4e32e99fbfcfd189cfae0b06d6cdcabc99c3714..4e64d07d5f5277e8653e169f55c2a8e463825e15 100644

--- a/content/browser/tracing/background_tracing_manager_impl.cc

+++ b/content/browser/tracing/background_tracing_manager_impl.cc

@@ -329,9 +329,16 @@ void BackgroundTracingManagerImpl::OnRuleTriggered(

StartTracing(triggered_rule->category_preset(),

base::trace_event::RECORD_UNTIL_FULL);

} else {

- // Reactive configs that trigger again while tracing should just

+ // Some reactive configs that trigger again while tracing should just

// end right away (to not capture multiple navigations, for example).

- trace_delay = -1;

+ // For others we just want to ignore the repeated trigger.

+ if (triggered_rule->stop_tracing_on_repeated_reactive()) {

+ trace_delay = -1;

+ } else {

+ if (!callback.is_null())

+ callback.Run(false);

+ return;

+ }

}

} else {

// In preemptive mode, a trigger starts finalizing a trace if one is