Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: content/browser/tracing/background_tracing_config_unittest.cc

Issue 2285853002: Reland of Background tracing: Added config option for repeated trigger behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorrect removal Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/background_tracing_config_unittest.cc
diff --git a/content/browser/tracing/background_tracing_config_unittest.cc b/content/browser/tracing/background_tracing_config_unittest.cc
index 1820a0b35c6bcb47a08400c64586e21b79e5c1d1..3aeedd9e024d80a2c0110fccfd40f036d40b386a 100644
--- a/content/browser/tracing/background_tracing_config_unittest.cc
+++ b/content/browser/tracing/background_tracing_config_unittest.cc
@@ -381,14 +381,17 @@ TEST_F(BackgroundTracingConfigTest, ReactiveConfigFromValidString) {
"\"trigger_delay\":30,\"trigger_name\":\"foo2\"}");
config = ReadFromJSONString(
"{\"mode\":\"REACTIVE_TRACING_MODE\",\"configs\": [{\"rule\": "
- "\"TRACE_AT_RANDOM_INTERVALS\",\"category\": \"BENCHMARK_DEEP\","
+ "\"TRACE_AT_RANDOM_INTERVALS\","
+ "\"stop_tracing_on_repeated_reactive\": true,"
+ "\"category\": \"BENCHMARK_DEEP\","
"\"timeout_min\":10, \"timeout_max\":20}]}");
EXPECT_TRUE(config);
EXPECT_EQ(config->tracing_mode(), BackgroundTracingConfig::REACTIVE);
EXPECT_EQ(config->rules().size(), 1u);
EXPECT_EQ(RuleToString(config->rules()[0]),
"{\"category\":\"BENCHMARK_DEEP\",\"rule\":\"TRACE_AT_RANDOM_"
- "INTERVALS\",\"timeout_max\":20,\"timeout_min\":10}");
+ "INTERVALS\",\"stop_tracing_on_repeated_reactive\":true,"
+ "\"timeout_max\":20,\"timeout_min\":10}");
}
TEST_F(BackgroundTracingConfigTest, ValidPreemptiveConfigToString) {
« no previous file with comments | « chrome/browser/tracing/navigation_tracing.cc ('k') | content/browser/tracing/background_tracing_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698