chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java - Issue 2285833002: Fix suggestion dismissing when underlying data changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java

Issue 2285833002: Fix suggestion dismissing when underlying data changes (Closed)

Patch Set: Import SuppressFBWarnings from the right namespace Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java

index 2b6b8ceb3a02ea9a1a4c643bbf9cb9a3f91e9b01..b18aca3f3276a008544d15af708392d7b1bafbee 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java

@@ -40,12 +40,6 @@ public class NewTabPageViewHolder extends RecyclerView.ViewHolder {

}

/**

- * Update the wrapped view's state as it is being swiped away.

- * @param dX The amount of horizontal displacement caused by user's action

- */

- public void updateViewStateForDismiss(float dX) {}

- /**

* Update the layout params for the view holder.

public void updateLayoutParams() {