Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 2285813002: Move work from ctor to onOnceBeforeDraw in ShowMipLevel GMs (Closed)

Created:
4 years, 3 months ago by robertphillips
Modified:
4 years, 3 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move work from ctor to onOnceBeforeDraw in ShowMipLevel GMs These were making debugging stroking more difficult than necessary GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2285813002 Committed: https://skia.googlesource.com/skia/+/55713afb7a531bbb6a345a42b5a25ad709d8fd19

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M gm/showmiplevels.cpp View 1 4 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 3 months ago (2016-08-26 16:38:49 UTC) #4
jvanverth1
lgtm
4 years, 3 months ago (2016-08-26 16:44:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285813002/20001
4 years, 3 months ago (2016-08-26 17:03:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 17:04:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/55713afb7a531bbb6a345a42b5a25ad709d8fd19

Powered by Google App Engine
This is Rietveld 408576698