Ability to add ResponseProvider

Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the webserver to build layers of ResponseProviders instead of creating a single monolithic provider.

BUG=none

Committed: https://crrev.com/85f30039f0396873a91da8618fc48dbc0ed099e8
Cr-Commit-Position: refs/heads/master@{#414732}

[edchin, 2016-08-26 15:30:07]

edchin@chromium.org changed reviewers:
+ baxley@chromium.org, eugenebut@chromium.org

[edchin, 2016-08-26 15:30:07]

baxley@chromium.org: Please review changes in 

eugenebut@chromium.org: Please review changes in

[Eugene But (OOO till 7-30), 2016-08-26 15:34:12]

lgtm, please explain in description the reason for the change

https://codereview.chromium.org/2285773002/diff/1/ios/web/public/test/http_se...
File ios/web/public/test/http_server_util.h (right):

https://codereview.chromium.org/2285773002/diff/1/ios/web/public/test/http_se...
ios/web/public/test/http_server_util.h:32: // Add a single custom provider.
s/Add/Adds

https://codereview.chromium.org/2285773002/diff/1/ios/web/public/test/http_se...
ios/web/public/test/http_server_util.h:33: // Takes ownership of the provider.
Optional NIT: Maybe remove line-break.

[edchin, 2016-08-26 15:47:04]

Description was changed from

==========
Ability to add ResponseProvider

BUG=none
==========

to

==========
Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the
webserver to build layers of ResponseProviders instead of creating a single
monolithic provider. 


BUG=none
==========

[edchin, 2016-08-26 15:47:32]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2016-08-26 15:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[edchin, 2016-08-26 15:49:29]

The CQ bit was unchecked by edchin@chromium.org

[edchin, 2016-08-26 15:55:46]

The CQ bit was checked by edchin@chromium.org

[edchin, 2016-08-26 15:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2285773002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-08-26 15:56:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 16:50:25]

Description was changed from

==========
Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the
webserver to build layers of ResponseProviders instead of creating a single
monolithic provider. 


BUG=none
==========

to

==========
Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the
webserver to build layers of ResponseProviders instead of creating a single
monolithic provider. 


BUG=none
==========

[commit-bot: I haz the power, 2016-08-26 16:50:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 16:53:45]

Description was changed from

==========
Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the
webserver to build layers of ResponseProviders instead of creating a single
monolithic provider. 


BUG=none
==========

to

==========
Ability to add ResponseProvider

Change makes for more modular architecture. This allows the user of the
webserver to build layers of ResponseProviders instead of creating a single
monolithic provider.

BUG=none

Committed: https://crrev.com/85f30039f0396873a91da8618fc48dbc0ed099e8
Cr-Commit-Position: refs/heads/master@{#414732}
==========

[commit-bot: I haz the power, 2016-08-26 16:53:46]

Patchset 2 (id:??) landed as
https://crrev.com/85f30039f0396873a91da8618fc48dbc0ed099e8
Cr-Commit-Position: refs/heads/master@{#414732}

[edchin, 2016-08-26 20:08:31]

Patchset #3 (id:40001) has been deleted