Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2285743002: [turbofan] Improve inline-exception tests. (Closed)

Created:
4 years, 3 months ago by bgeron
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve inline-exception tests. - Make constants more interesting. - Add an addition to be done after the inlined call in the try-block. - On command line, have a bit more output. - New alternative that deopts from unoptimized code. BUG= R=jarin Committed: https://crrev.com/d90d76bdb5bfa095adfb95c445953660bbf6d5e8 Cr-Commit-Position: refs/heads/master@{#38974}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename noopt function. Generate some type feedback for noopt functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1100 lines, -852 lines) Patch
M test/mjsunit/compiler/inline-exception-1.js View 1 87 chunks +517 lines, -419 lines 0 comments Download
M test/mjsunit/compiler/inline-exception-2.js View 1 98 chunks +504 lines, -410 lines 0 comments Download
M tools/gen-inlining-tests.py View 1 15 chunks +79 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bgeron
Please take a look. This adds tests such as the following: f = function f____2_t___c_l____ld ...
4 years, 3 months ago (2016-08-26 14:47:06 UTC) #3
Jarin
lgtm https://codereview.chromium.org/2285743002/diff/1/test/mjsunit/compiler/inline-exception-1.js File test/mjsunit/compiler/inline-exception-1.js (right): https://codereview.chromium.org/2285743002/diff/1/test/mjsunit/compiler/inline-exception-1.js#newcode101 test/mjsunit/compiler/inline-exception-1.js:101: function increaseAndThrow42_noopt_outer() { The "noopt" in the name ...
4 years, 3 months ago (2016-08-29 09:48:07 UTC) #6
bgeron
How about increaseAndThrow42_calls_noopt? On 2016/08/29 09:48:07, Jarin wrote: > lgtm > > https://codereview.chromium.org/2285743002/diff/1/test/mjsunit/compiler/inline-exception-1.js > File ...
4 years, 3 months ago (2016-08-29 09:51:47 UTC) #7
Jarin
On 2016/08/29 09:51:47, bgeron wrote: > How about increaseAndThrow42_calls_noopt? Sounds good.
4 years, 3 months ago (2016-08-29 10:18:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2285743002/20001
4 years, 3 months ago (2016-08-29 10:51:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-29 11:16:42 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 11:17:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d90d76bdb5bfa095adfb95c445953660bbf6d5e8
Cr-Commit-Position: refs/heads/master@{#38974}

Powered by Google App Engine
This is Rietveld 408576698