Issue 228573003: ARM64: Use pair memory access in deoptimizer entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228573003: ARM64: Use pair memory access in deoptimizer entry (Closed)

Created:
6 years, 8 months ago by m.m.capewell

Modified:
6 years, 8 months ago

Reviewers:
ulan, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM64: Use pair memory access in deoptimizer entry BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20613

Patch Set 2 : Fix missing src_offset #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -17 lines)			Patch
	M	src/arm64/deoptimizer-arm64.cc	View	1	2 chunks	+42 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc File src/arm64/deoptimizer-arm64.cc (right): https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc#newcode170 src/arm64/deoptimizer-arm64.cc:170: __ Peek(scratch1, (reg_count - 1) * reg_size); Missing src_offset: ...

6 years, 8 months ago (2014-04-09 11:42:41 UTC) #2

m.m.capewell

On 2014/04/09 11:42:41, ulan wrote: > https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc > File src/arm64/deoptimizer-arm64.cc (right): > > https://codereview.chromium.org/228573003/diff/1/src/arm64/deoptimizer-arm64.cc#newcode170 > ...

6 years, 8 months ago (2014-04-09 12:14:00 UTC) #3

m.m.capewell

6 years, 8 months ago (2014-04-09 12:28:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20613 (presubmit successful).

Expand Messages | Collapse Messages

Issue 228573003: ARM64: Use pair memory access in deoptimizer entry (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix missing src_offset #

Messages