Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2285723002: Use DWARF 3 on android, instead of DWARF 4. (Closed)
Patch Set: Restrict to just android, and fix arg order Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 47a732b3b53e83aca5c8fa52428b605e7814fd5b..ad6cc65677497ad7fd377cb9b144d32eff52c791 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1525,6 +1525,14 @@ config("symbols") {
# dump_syms, so this is still required (https://crbug.com/622406).
cflags += [ "-fno-standalone-debug" ]
}
+ } else if (is_android) {
+ # Breakpad can't handle DWARF 4 symbols properly yet, so use DWARF 3
+ # explicitly on android where we are hitting https://crbug.com/638485.
+ # The arguments MUST be in this order because of a gcc arg parsing bug.
+ cflags = [
+ "-gdwarf-3",
+ "-g2",
+ ]
} else {
cflags = [ "-g2" ]
}
@@ -1550,7 +1558,17 @@ config("minimal_symbols") {
ldflags = [ "/DEBUG" ]
}
} else {
- cflags = [ "-g1" ]
+ if (is_android) {
+ # Breakpad can't handle DWARF 4 symbols properly yet, so use DWARF 3
+ # explicitly on android where we are hitting https://crbug.com/638485.
+ # The arguments MUST be in this order because of a gcc arg parsing bug.
+ cflags = [
+ "-gdwarf-3",
+ "-g1",
+ ]
+ } else {
+ cflags = [ "-g1" ]
+ }
if (use_debug_fission) {
cflags += [ "-gsplit-dwarf" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698